add bypass header config option to maxmind_acl plugin#13160
Open
traeak wants to merge 5 commits into
Open
Conversation
Contributor
|
@traeak ping me when the Copilot issues has been addressed. |
zwoop
previously approved these changes
May 21, 2026
Contributor
zwoop
left a comment
zwoop
left a comment
There was a problem hiding this comment.
One real comment here, and one nitpick. The question on the new function returning an unused bool is real, but if it's intended, you can leave it. Just reads oddly. The nitpick is up to you.
Approving, but feel free to make one or both of the raised questions.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+440
to
+447
| if (!bypassNode) { | ||
| Dbg(dbg_ctl, "No bypass set"); | ||
| return; | ||
| } | ||
| if (bypassNode.IsNull()) { | ||
| Dbg(dbg_ctl, "bypass node is NULL"); | ||
| return; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to use an optional header/value to bypass running this plugin in the TSRemapDoRemap stage.
maxmind config yaml looks like:
If this option is not provided then the plugin runs as normal in enforcing mode.
Exact header and value is required.